-
Notifications
You must be signed in to change notification settings - Fork 8
Add ogc endpoints #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grallewellyn
wants to merge
13
commits into
develop
Choose a base branch
from
add-ogc-endpoints
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ogc endpoints #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujen1412
previously approved these changes
Aug 21, 2025
…ready testing all the returns
sujen1412
previously approved these changes
Jan 7, 2026
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
Author
|
@sujen1412 This PR is ready to merge unless we want the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: MAAP-Project/Community#1166
Description
We added the OGC endpoints so we needed to add the implementation to maap-py for users who prefer this approach
Added that the _ogc is just for developers testing and we need to change that later
Overview of work done
Called all the OGC endpoints added to the API
Overview of verification done
Added test_ogc_functions.py but most testing is done here: https://github.com/MAAP-Project/maap-api-nasa/blob/develop/test/api/endpoints/test_ogc.py
Overview of integration done
Tested in a notebook in DIT
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request